Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to mark lesson as done for a specified student #69

Merged

Conversation

justinlengch
Copy link

No description provided.

@justinlengch justinlengch added the priority.Medium Nice to have label Apr 4, 2024
@justinlengch justinlengch added this to the V1.3 milestone Apr 4, 2024
@justinlengch justinlengch self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 4.00000% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 68.81%. Comparing base (67d05b6) to head (595c771).

Files Patch % Lines
...eedu/address/logic/commands/MarkLessonCommand.java 0.00% 28 Missing ⚠️
.../address/logic/parser/MarkLessonCommandParser.java 0.00% 14 Missing ⚠️
...seedu/address/logic/commands/AddLessonCommand.java 0.00% 5 Missing ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     70.77%   68.81%   -1.97%     
  Complexity      455      455              
============================================
  Files            79       81       +2     
  Lines          1615     1661      +46     
  Branches        161      167       +6     
============================================
  Hits           1143     1143              
- Misses          427      473      +46     
  Partials         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@leepoeaik leepoeaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a necessary change! Wow so useful! LGTM!

@justinlengch justinlengch merged commit b805baa into AY2324S2-CS2103T-T16-4:master Apr 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants